fix(ext/node): fix multiple deepEqual comparison issues#32763
Merged
bartlomieju merged 1 commit intomainfrom Mar 16, 2026
Merged
fix(ext/node): fix multiple deepEqual comparison issues#32763bartlomieju merged 1 commit intomainfrom
bartlomieju merged 1 commit intomainfrom
Conversation
- Fix invalid Date comparison (NaN !== NaN) by using NumberIsNaN - Fix Date type check order to prevent TypeError on non-Date objects - Fix loose array comparison for null/undefined equivalence - Fix setObjectEquiv to properly reject non-matching primitives in strict mode instead of skipping them - Fix mapObjectEquiv with same pattern for Map key comparison - Reject Promise comparison by reference only (not structurally) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
55fc182 to
5a28d84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
test-assert-deep.jscompat test from #32706.NaN !== NaNcomparison by usingNumberIsNaNforDate.getTime()results, so two invalid dates with the same properties are considered deeply equalisDate(val2)before callingDatePrototypeGetTime(val2)to preventTypeErroron non-Date objects with[Symbol.toStringTag] = 'Date'nullandundefinedto be loosely equal in arrays by deferring toinnerDeepEqualin loose mode instead of short-circuitingsetObjectEquivto properly reject non-matching primitives in strict mode (was incorrectly continuing instead of returning false)mapObjectEquivwith same pattern — checkb.has(key1)before skipping primitive keysEnabled tests
test-assert-deep.js(all 52 subtests pass)Test plan
test-assert-deep.jspasses via./x test-compat🤖 Generated with Claude Code