fix(repl): fix panic when pressing Tab at beginning of line#32750
Merged
bartlomieju merged 3 commits intomainfrom Mar 17, 2026
Merged
fix(repl): fix panic when pressing Tab at beginning of line#32750bartlomieju merged 3 commits intomainfrom
bartlomieju merged 3 commits intomainfrom
Conversation
When the cursor was at the beginning of a line containing text (e.g. typing `Date(` then pressing Home and Tab), the REPL's fallback tab completion would panic due to a usize underflow. The `get_expr_from_line_at_pos` function was looking at text *after* the cursor to determine the expression, then subtracting its length from the cursor position (0), causing an underflow. Fix: only consider text before the cursor position when determining the expression to complete, which is the correct behavior for tab completion. Closes #28038 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_expr_from_line_at_posfunction was looking at text after the cursor to determine the completion expression, then subtracting its length from cursor position 0, causing an underflow tousize::MAXReproduction steps
denoto enter REPLDate(Test plan
Dat+ Tab completes toDate)Closes #28038
🤖 Generated with Claude Code