fix(core): don't panic in to_v8_error when JS error builder callback fails#32749
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Mar 17, 2026
Merged
fix(core): don't panic in to_v8_error when JS error builder callback fails#32749bartlomieju merged 2 commits intodenoland:mainfrom
bartlomieju merged 2 commits intodenoland:mainfrom
Conversation
…fails When the JS error builder callback throws (e.g. due to stack overflow or Array.prototype pollution), fall back to returning the plain message string instead of panicking. This handles cases where the V8 call stack is exhausted and the callback itself can't execute. Closes denoland#28436 Closes denoland#29824 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_v8_errorthrows (e.g. due to stack overflow orObject.prototype/Array.prototypepollution), fall back to returning the plain message string instead of panickingCloses #28436
Closes #29824
Closes #27720
Test plan
test_to_v8_error_handles_stack_overflow_in_builder— simulates the builder throwingRangeErrorand verifies fallbacktest_to_v8_error_handles_null_builder_exceptionstill passesdeno_core-0.340.0due toUncaught RangeError: Maximum call stack size exceeded#28436 repro script no longer panicsArray.prototype["0"]is defined with a getter andDeno.readTextFileis called #29824 repro script no longer panics (proper error message shown)Object.prototype.setandDeno.Commandtogether #27720 repro script no longer panics🤖 Generated with Claude Code