fix(ext/node): fix IPC message prototype for child_process JSON#32731
Merged
fraidev merged 2 commits intodenoland:mainfrom Mar 16, 2026
Merged
fix(ext/node): fix IPC message prototype for child_process JSON#32731fraidev merged 2 commits intodenoland:mainfrom
fraidev merged 2 commits intodenoland:mainfrom
Conversation
…lization Deno's serde_v8 layer deserializes JSON objects with null prototype (Object.create(null)), but Node.js IPC messages should have Object.prototype (as if from JSON.parse). This caused assert.deepStrictEqual to fail when comparing IPC messages. For the JSON serialization mode, re-parse the message through JSON.parse(JSON.stringify(msg)) to restore normal prototypes.
bartlomieju
requested changes
Mar 14, 2026
| // serde_v8 deserializes objects with null prototype, but Node.js IPC | ||
| // messages should have Object.prototype (as if from JSON.parse). | ||
| if (serialization === "json" && msg !== null && typeof msg === "object") { | ||
| msg = JSON.parse(JSON.stringify(msg)); |
Member
There was a problem hiding this comment.
This is gonna be horrible for performance. Can you think of some other solution?
Contributor
Author
There was a problem hiding this comment.
Yeah, that is bad. I created a restorePrototype function to do it via walk the tree.
bartlomieju
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deno's serde_v8 layer deserializes JSON objects with null prototype (Object.create(null)), but Node.js IPC messages should have Object.prototype (as if from JSON.parse). This caused assert.deepStrictEqual to fail when comparing IPC messages.
For the JSON serialization mode, re-parse the message through JSON.parse(JSON.stringify(msg)) to restore normal prototypes.