fix(ext/node): validate handle type in child_process send()#32711
Merged
fraidev merged 2 commits intodenoland:mainfrom Mar 16, 2026
Merged
fix(ext/node): validate handle type in child_process send()#32711fraidev merged 2 commits intodenoland:mainfrom
fraidev merged 2 commits intodenoland:mainfrom
Conversation
When `send(msg, handle)` is called with an invalid handle type (e.g. a string), Node.js throws ERR_INVALID_HANDLE_TYPE. Deno was hitting a generic `notImplemented()` error instead, since the handle validation was missing before the not-implemented guard. Now validates that the handle is a recognized type (net.Socket, Server, or object with _handle) before rejecting, matching Node.js error behavior.
bartlomieju
reviewed
Mar 14, 2026
Comment on lines
+1868
to
+1869
| !(handle?.constructor?.name === "Server") && | ||
| !(handle?.constructor?.name === "Socket") |
Member
There was a problem hiding this comment.
This looks brittle... shouldn't it be accessing actual classes?
Contributor
Author
There was a problem hiding this comment.
good catch, I changed to use checks via the actual classes
d5176d1 to
de5c978
Compare
bartlomieju
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
send(msg, handle)is called with an invalid handle type (e.g. a string), Node.js throws ERR_INVALID_HANDLE_TYPE. Deno was hitting a genericnotImplemented()error instead, since the handle validation was missing before the not-implemented guard.Now validates that the handle is a recognized type (net.Socket, Server, or object with _handle) before rejecting, matching Node.js error behavior.