perf(lsp): replace dissimilar with imara-diff#32700
Merged
bartlomieju merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Replace the `dissimilar` crate with `imara-diff` (already used in `deno_resolver`) for computing LSP formatting text edits. This removes a dependency from the project and unifies on a single diffing library. The diff granularity changes from character-level to line-level, which is the standard approach used by most LSP implementations. The edits are semantically equivalent — applying them produces the same formatted result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #30644 (comment)
dissimilarwithimara-difffor computing LSP formatting text edits, unifying on a single diffing library across the codebasedissimilardependency entirely from the workspaceTest plan
cli/lsp/text.rsupdated and passing🤖 Generated with Claude Code