fix(ext/node): include prototype env vars in child_process spawn#32699
Merged
fraidev merged 3 commits intodenoland:mainfrom Mar 14, 2026
Merged
fix(ext/node): include prototype env vars in child_process spawn#32699fraidev merged 3 commits intodenoland:mainfrom
fraidev merged 3 commits intodenoland:mainfrom
Conversation
The env key collection loop had `Object.hasOwn()` filtering despite the comment saying "Prototype values are intentionally included". This made `for...in` pointless since it only kept own properties. Node.js includes prototype-chain env vars when spawning child processes, and this test explicitly verifies that behavior.
bartlomieju
approved these changes
Mar 14, 2026
Member
bartlomieju
left a comment
There was a problem hiding this comment.
LGTM, you should add a comment ignoring lint error with explanation about it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The env key collection loop had
Object.hasOwn()filtering despite the comment saying "Prototype values are intentionally included". This madefor...inpointless since it only kept own properties.Node.js includes prototype-chain env vars when spawning child processes, and this test explicitly verifies that behavior.