fix(ext/web): support %j JSON format specifier in console.log#32684
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Mar 13, 2026
Merged
fix(ext/web): support %j JSON format specifier in console.log#32684bartlomieju merged 2 commits intodenoland:mainfrom
bartlomieju merged 2 commits intodenoland:mainfrom
Conversation
Closes denoland#32680 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tango992
reviewed
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Can we use something like this instead https://github.com/nodejs/node/blob/70f6b58ac655234435a99d72b857dd7b316d34bf/lib/internal/util/inspect.js#L2477-L2499 ?
Only catch circular reference TypeError in %j JSON formatting, re-throwing other errors (e.g. BigInt) instead of swallowing them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%jformat specifier inconsole.logand related methods, which JSON-stringifies the argument (matching Node.js behavior)[Circular]instead of throwingCloses #32680
Test plan
%jwith objects, primitives, arrays, multiple specifiers, and circular references./x test-unit consolepasses🤖 Generated with Claude Code