fix(ext/crypto): support structuredClone for CryptoKey#32674
Merged
bartlomieju merged 6 commits intodenoland:mainfrom Mar 13, 2026
Merged
fix(ext/crypto): support structuredClone for CryptoKey#32674bartlomieju merged 6 commits intodenoland:mainfrom
bartlomieju merged 6 commits intodenoland:mainfrom
Conversation
Uses the cloneable resource registry from denoland#32672 to enable structured cloning of CryptoKey objects. This allows CryptoKeys (including non-extractable ones) to be passed to Workers via postMessage and cloned with structuredClone(). Closes denoland#12734 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
crowlKats
approved these changes
Mar 12, 2026
Uses the cloneable resource registry to enable structured cloning of DOMException objects. Serializes message, name, and stack; code is derived from name on deserialization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The hostObjectBrand symbol property was enumerable, causing Node's deepStrictEqual to compare the function instances and fail since each object has a different closure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
structuredClone()andpostMessage()forCryptoKeyobjects using the cloneable resource registry from feat(core): add cloneable resource registry for structured clone #32672exportKeyAPICloses #12734