fix(ext/node): fix TLS JSStreamSocket resource leak causing process hang#32325
Merged
fraidev merged 9 commits intodenoland:mainfrom Mar 11, 2026
Merged
Conversation
5ae8e87 to
22c2bf8
Compare
22c2bf8 to
90bf3e7
Compare
90bf3e7 to
7d972d9
Compare
kajukitli
approved these changes
Mar 10, 2026
Contributor
kajukitli
left a comment
There was a problem hiding this comment.
Reviewed the changes. No issues found.
kajukitli
approved these changes
Mar 10, 2026
Contributor
kajukitli
left a comment
There was a problem hiding this comment.
Reviewed the changes. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30556
When
tls.connect({ socket })receives a non-net.Socketstream (e.g. mssql/tedious wrapping TDS framing in a Duplex via native-duplexpair), Deno creates aJSStreamSocketto bridge the JS stream to Rust TLS resources. A circularRcdependency betweenJSDuplexResourceandJSStreamTlsResourceprevented either from being dropped after close, keeping a pendingcore.read()alive and the event loop running indefinitely.Fixes at three layers:
(
tls.rs): AddResource::close()toJSDuplexResourceusingAtomicBool+tokio::sync::Notifyto break pending reads without mutex deadlock, releasing the circularRcdependency.(
_tls_wrap.js): AddJSStreamSocket.close()so the_onClose() -> kStreamBaseField.close()path properly closes both TLS and channel resources.(
stream_wrap.ts): TreatDeno.errors.UnexpectedEofas EOF alongsideInterruptedandBadResource, fixing a pre-existing unhandled error on TLS peer close.