fix(ext/node): implement timeout and killSignal for spawn()#32283
Merged
fraidev merged 1 commit intodenoland:mainfrom Feb 23, 2026
Merged
fix(ext/node): implement timeout and killSignal for spawn()#32283fraidev merged 1 commit intodenoland:mainfrom
fraidev merged 1 commit intodenoland:mainfrom
Conversation
Fixes the `timeout` and `killSignal` options for `child_process.spawn()` (and `fork()`, which delegates to `spawn()`). Previously these options were accepted but silently ignored. The fix sets a `setTimeout` after spawning that kills the child with the specified `killSignal` (default: `"SIGTERM"`) if the process hasn't exited within `timeout` ms. The timer is cleared if the process exits naturally before the deadline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19517
Fixes the
timeoutandkillSignaloptions forchild_process.spawn()(andfork(), which delegates tospawn()). Previously these options were accepted but silently ignored.The fix sets a
setTimeoutafter spawning that kills the child with the specifiedkillSignal(default:"SIGTERM") if the process hasn't exited withintimeoutms. The timer is cleared if the process exits naturally before the deadline.