Skip to content

fix(ext/node): support URL in child_process.fork modulePath#32268

Merged
bartlomieju merged 1 commit intodenoland:mainfrom
bartlomieju:fix/fork-url-support
Feb 23, 2026
Merged

fix(ext/node): support URL in child_process.fork modulePath#32268
bartlomieju merged 1 commit intodenoland:mainfrom
bartlomieju:fix/fork-url-support

Conversation

@bartlomieju
Copy link
Copy Markdown
Member

Summary

  • Adds support for passing URL objects as the modulePath argument to child_process.fork(), matching Node.js behavior
  • Converts URL to file path using toPathIfFileURL() before string validation
  • Adds unit test for fork() with a URL argument

Closes #28137

Test plan

  • cargo test child_process_test passes
  • Manual test with a.mjs / b.js reproduction from the issue works

🤖 Generated with Claude Code

Closes denoland#28137

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bartlomieju bartlomieju requested a review from fraidev February 23, 2026 10:01
@bartlomieju bartlomieju enabled auto-merge (squash) February 23, 2026 15:29
Copy link
Copy Markdown
Contributor

@fraidev fraidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 6998e65 into denoland:main Feb 23, 2026
216 of 218 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validator rejects URL's passed to node:child_process fork function, but types and docs say URL is supported

2 participants