fix(ext/node): add openAsBlob export to node:fs#32261
Merged
bartlomieju merged 2 commits intodenoland:mainfrom Feb 23, 2026
Merged
fix(ext/node): add openAsBlob export to node:fs#32261bartlomieju merged 2 commits intodenoland:mainfrom
openAsBlob export to node:fs#32261bartlomieju merged 2 commits intodenoland:mainfrom
Conversation
Implements `fs.openAsBlob()` which returns a Promise<Blob> containing the file's data, matching the Node.js API. Closes denoland#31036 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
If I understand correctly, the implementation is to read the file completely into memory. This is inconsistent with browser and nodejs behavior and makes the API much less useful. @jimmywarting explicitly states and recommends this in every post: |
Member
Author
|
Thanks I just started the release so it's gonna be fixed in a patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.openAsBlob()which reads a file and returns aPromise<Blob>, matching the Node.js APInode:fstypeoption, and error handling for non-existent filesCloses #31036
Test plan
cargo test unit_node::fs_testpassesimport { openAsBlob } from "node:fs"works correctly🤖 Generated with Claude Code