fix(ext/node): add worker_threads stdin support#32165
Merged
bartlomieju merged 3 commits intodenoland:mainfrom Feb 14, 2026
Merged
fix(ext/node): add worker_threads stdin support#32165bartlomieju merged 3 commits intodenoland:mainfrom
bartlomieju merged 3 commits intodenoland:mainfrom
Conversation
When `{ stdin: true }` is passed to the Worker constructor, creates a
writable `worker.stdin` stream that pipes data to the worker's
`process.stdin` via internal WORKER_STDIN/WORKER_STDIN_END messages.
Also fixes stdout/stderr forwarding to preserve binary data instead of
converting to String(), enabling correct transfer of binary content
through worker stdio pipes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
littledivy
approved these changes
Feb 14, 2026
450ab0d to
d594eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
worker.stdinsupport when{ stdin: true }is passed to theWorkerconstructorWritablestream (worker.stdin) that sendsWORKER_STDIN/WORKER_STDIN_ENDmessages to the worker viapostMessageprocess.stdinwith aReadablethat receives data from those messages, using an earlyaddEventListenerwithstopImmediatePropagation()to hide internal messages from user handlerschunkdirectly instead ofString(chunk))test-worker-stdio.js,test-worker-stdio-flush.js,test-worker-stdio-flush-inflight.jsTest plan
cargo test --test node_compat parallel -- --filter "test-worker-stdio"— 3 new tests passcargo test --test node_compat parallel -- --filter "test-worker-no-stdin-stdout-interaction"— existing test still passestools/lint.jspassestools/format.jspasses🤖 Generated with Claude Code