fix(ext/node): emit error event for worker_threads terminal errors#32052
Merged
littledivy merged 5 commits intodenoland:mainfrom Feb 5, 2026
Merged
fix(ext/node): emit error event for worker_threads terminal errors#32052littledivy merged 5 commits intodenoland:mainfrom
littledivy merged 5 commits intodenoland:mainfrom
Conversation
bartlomieju
reviewed
Feb 4, 2026
ext/node/polyfills/worker_threads.ts
Outdated
Comment on lines
+240
to
+241
| // When prepareStackTrace throws, stack should be undefined | ||
| // like Node.js behavior |
Member
There was a problem hiding this comment.
If prepareStackTrace throws then the control flow will exit this function, wouldn't it?
Member
Author
There was a problem hiding this comment.
No this is the host-side, this is for when prepareStackTrace throws in the worker
Signed-off-by: Divy <dj.srivastava23@gmail.com>
bartlomieju
approved these changes
Feb 5, 2026
Signed-off-by: Divy <dj.srivastava23@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test-worker-error-stack-getter-throws.js