fix(ext/node): implement sqlite' SQLTagStore#31945
Merged
Tango992 merged 13 commits intodenoland:mainfrom Jan 30, 2026
Merged
Conversation
bartlomieju
reviewed
Jan 30, 2026
| let db = db.as_ref().ok_or(SqliteError::AlreadyClosed)?; | ||
|
|
||
| v8_static_strings! { | ||
| LAST_INSERT_ROW_ID = "lastInsertRowid", |
Member
There was a problem hiding this comment.
Isn't this a typo? Shouldn't it be lastInsertRowId?
Member
There was a problem hiding this comment.
Looking at Node's code it seems it's not
bartlomieju
reviewed
Jan 30, 2026
| r: i32, | ||
| db: *mut ffi::sqlite3, | ||
| ) -> Result<(), SqliteError> { | ||
| if r != ffi::SQLITE_OK { |
Member
There was a problem hiding this comment.
Nitpick for the future - use early returns instead of big if statements
bartlomieju
reviewed
Jan 30, 2026
| } | ||
| }); | ||
|
|
||
| Deno.test("sql.run inserts data", () => { |
Member
There was a problem hiding this comment.
Could we just update our suite instead of adding a test manually?
Contributor
Author
There was a problem hiding this comment.
Do you mean we should omit the beforeEach and paste it on each test case on our suite? Wouldn't it be overwritten once we bump the node version?
Member
There was a problem hiding this comment.
Oh, sorry. I thought the problem was the test is only avilable in latest Node.js checkout, but we actually don't support this API
bartlomieju
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation is based on Node.js v24.12.0
It passes test cases on https://github.com/nodejs/node/blob/v24.12.0/test/parallel/test-sqlite-template-tag.js, but since we don't yet implement
beforeEachofnode:testthe test will fail. I ported the tests to our node unit tests.