feat: Windows on ARM builds#31917
Merged
littledivy merged 23 commits intodenoland:mainfrom Jan 30, 2026
Merged
Conversation
Member
|
Looks like you need to update esbuild to include ARM build too. |
Member
Author
|
esbuild ships with win32-arm64 binaries. I added runner to the CI in esbuild_client repo: denoland/esbuild_client#17 |
bartlomieju
reviewed
Jan 23, 2026
bartlomieju
reviewed
Jan 30, 2026
bartlomieju
reviewed
Jan 30, 2026
| let context = TestContext::default(); | ||
| let socket_path = if cfg!(windows) { | ||
| PathRef::new(r"\\.\pipe\deno-permission-broker") | ||
| PathRef::new(r"\\.\pipe\deno-permission-broker-nonexistent") |
Member
There was a problem hiding this comment.
Why did we need this change?
Member
Author
There was a problem hiding this comment.
it was flaky, other permission broker test also uses the same socket path.
bartlomieju
reviewed
Jan 30, 2026
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "if": "notWindowsArm", | |||
Member
Author
There was a problem hiding this comment.
this does deno upgrade which wont work because there isnt a windows arm release yet
bartlomieju
reviewed
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8422
Closes #13331