Skip to content

fix(ext/node): add FileHandle#writeFile#25555

Merged
lucacasonato merged 2 commits intodenoland:mainfrom
kt3k:fix-node-fs-file-handle-write-file
Sep 11, 2024
Merged

fix(ext/node): add FileHandle#writeFile#25555
lucacasonato merged 2 commits intodenoland:mainfrom
kt3k:fix-node-fs-file-handle-write-file

Conversation

@kt3k
Copy link
Copy Markdown
Contributor

@kt3k kt3k commented Sep 10, 2024

This PR adds writeFile methods of FileHandle class https://nodejs.org/api/fs.html#filehandlewritefiledata-options

closes #25528

part of #25554

@kt3k kt3k changed the title fix(ext/node): add FileHandle#writeFile fix(ext/node): add FileHandle#writeFile Sep 10, 2024
Copy link
Copy Markdown
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit 8bdd364 into denoland:main Sep 11, 2024
@kt3k kt3k deleted the fix-node-fs-file-handle-write-file branch September 11, 2024 10:17
@kt3k kt3k mentioned this pull request Sep 10, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deno fails to run puppeteer

3 participants