feat: rename Deno.Server to Deno.HttpServer#20842
Merged
bartlomieju merged 2 commits intoOct 27, 2023
Merged
Conversation
Keeps the old name around for backwards compat.
074f4a4 to
90419d7
Compare
bartlomieju
requested changes
Oct 9, 2023
bartlomieju
left a comment
Member
There was a problem hiding this comment.
It's fine, but I'm gonna mark it as "Request changes" so we don't land it by mistake before v1.38. I'll make sure this is included in the minor release.
Contributor
|
LGTM to land in 1.38! |
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
bartlomieju
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the old name around for backwards compat.
Closes #20840