feat: bring back WebGPU by crowlKats · Pull Request #20812 · denoland/deno

crowlKats · 2023-10-06T10:01:57Z

runtime/build.rs

sigmaSd · 2023-10-06T20:01:56Z

does this not impact startup time anymore ?

lino-levan · 2023-10-10T15:31:32Z

Linking this PR for context: servo/core-foundation-rs#608

hastebrot · 2023-10-11T06:14:30Z

if it impacts startup time then it should be put behind a flag, if this helps. otherwise everything will slowdown including deployctl (deno deploy cli) which currently is 20 times faster than az (azure cli tool) just to output the help text on my machine.

.cargo/config.toml

crowlKats · 2023-10-11T14:46:09Z

We are working on reducing the startup time. A flag would not help. Also, the startup time originally was increased by 3ms, and now is at 1ms increase, and we are working on further reducing it.

chances · 2023-10-20T15:11:02Z

Requires a wgpu release...

@crowlKats What is missing from wgpu, exactly?

crowlKats · 2023-10-20T15:14:14Z

Requires a wgpu release...

@crowlKats What is missing from wgpu, exactly?

@chances due to our setup with the wgpu repo, we require the js & rust code to be pulled from a commit that is a release of wgpu.
The blockers for wgpu release from my end is a core-graphics-types release and then a metal-rs release.

petamoriken

Added many suggestions related to inspect 🙇

ext/webgpu/01_webgpu.js

ext/webgpu/02_surface.js

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

# Conflicts: # Cargo.lock # Cargo.toml # cli/js/40_testing.js # tools/README.md

KnorpelSenf · 2023-12-08T12:39:50Z

This fixes #21514, feel free to update the description

ry · 2023-12-08T15:07:13Z

@crowlKats can you provide start up time benchmarks? Also max RSS for a blank file?

# Conflicts: # Cargo.lock # Cargo.toml

crowlKats · 2023-12-08T15:43:15Z

@ry

crowlKats · 2023-12-08T15:59:57Z

Memory:

bartlomieju · 2023-12-08T16:28:21Z

On my machine:

hyperfine --warmup 30 -S none './target/release/deno run empty.js' 'deno run empty.js'
Benchmark 1: ./target/release/deno run empty.js
  Time (mean ± σ):      16.3 ms ±   1.0 ms    [User: 10.3 ms, System: 3.9 ms]
  Range (min … max):    15.4 ms …  22.5 ms    189 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet PC without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Benchmark 2: deno run empty.js
  Time (mean ± σ):      14.3 ms ±   0.3 ms    [User: 10.1 ms, System: 4.2 ms]
  Range (min … max):    13.8 ms …  16.4 ms    205 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet PC without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Summary
  'deno run empty.js' ran
    1.14 ± 0.07 times faster than './target/release/deno run empty.js'

/usr/bin/time -l ./target/release/deno run empty.js
        0.03 real         0.01 user         0.00 sys
            38584320  maximum resident set size

/usr/bin/time -l deno run empty.js
        0.02 real         0.01 user         0.00 sys
            38273024  maximum resident set size

mmastrac · 2023-12-08T16:29:38Z

/bench startup_hello_world,startup_nop_empty,startup_nop_trivial

denobot · 2023-12-08T16:29:41Z

startup_hello_world

	time	user	system	relative
node	27.887 ms	21.973 ms	7.132 ms	+194.9%
bun	9.456 ms	4.116 ms	6.413 ms	best
deno	15.391 ms	9.995 ms	6.672 ms	+62.8%
deno-baseline	15.152 ms	10.052 ms	6.365 ms	+60.2%

startup_nop_empty

	time	user	system	relative
node	22.526 ms	16.879 ms	6.872 ms	+681.6%
bun	2.882 ms	0.918 ms	1.843 ms	best
deno	15.263 ms	10.067 ms	6.464 ms	+429.6%
deno-baseline	14.955 ms	9.424 ms	6.802 ms	+418.9%

startup_nop_trivial

	time	user	system	relative
node	21.986 ms	16.613 ms	6.58 ms	+92.4%
bun	11.426 ms	5.124 ms	7.47 ms	best
deno	15.137 ms	10.211 ms	6.192 ms	+32.5%
deno-baseline	14.952 ms	9.681 ms	6.539 ms	+30.9%

^{start: Fri, 08 Dec 2023 16:29:41 GMT
id: 1cab344b-ca4a-4422-a124-4a40b7f564e8
server: 093a6a04-1f84-4244-a37b-9a2e40cc5782}

mmastrac · 2023-12-08T16:53:17Z

Comparing to deno 1.38.5 on my machine after a clean && build I see no impact:

09:52 $ hyperfine --warmup 30 -S none './target/release/deno run /tmp/empty.js' './target/release/deno-2 run /tmp/empty.js'
Benchmark 1: ./target/release/deno run /tmp/empty.js
  Time (mean ± σ):      13.3 ms ±   0.5 ms    [User: 9.9 ms, System: 3.4 ms]
  Range (min … max):    12.6 ms …  16.3 ms    212 runs
 
Benchmark 2: ./target/release/deno-2 run /tmp/empty.js
  Time (mean ± σ):      13.2 ms ±   0.4 ms    [User: 9.8 ms, System: 3.4 ms]
  Range (min … max):    12.4 ms …  15.3 ms    233 runs
 
Summary
  './target/release/deno-2 run /tmp/empty.js' ran
    1.01 ± 0.05 times faster than './target/release/deno run /tmp/empty.js'

cli/js/40_testing.js

bartlomieju · 2023-12-08T21:44:09Z

cli/tests/unit/webgpu_test.ts

+
+let isCI: boolean;
+try {
+  isCI = (Deno.env.get("CI")?.length ?? 0) > 0;


This is 4th place we define this env var :) we should move it to test_util.ts in a follow up. Can you handle that @crowlKats?

cli/tests/unit/webgpu_test.ts

ext/node/polyfill.rs

ext/webgpu/02_surface.js

ext/webgpu/README.md

bartlomieju · 2023-12-08T21:47:26Z

runtime/js/98_global_scope.js

+  gpu: {
+    configurable: true,
+    enumerable: true,
+    get() {
+      webidl.assertBranded(this, NavigatorPrototype);
+      loadWebGPU();
+      return webgpu.gpu;
+    },
+  },


What about set()? I think on the web one can override this value

nope, not overwritable, however all the navigator getters should have no-op setters. I'll fix that up in a follow up with tests.

lino-levan · 2023-12-09T05:25:12Z

Nice work Leo (and the whole Deno team). Excited to see this brought back into Deno.

crowlKats added 2 commits October 4, 2023 16:22

bring back webgpu infrastructure

bc3fbf5

pull in webgpu

1b1e475

crowlKats commented Oct 6, 2023

View reviewed changes

runtime/build.rs Outdated Show resolved Hide resolved

use git dep

6d56745

birkskyum mentioned this pull request Oct 9, 2023

WebGPU Implementation #7863

Closed

crowlKats added 2 commits October 10, 2023 17:08

fix

b54794f

feat(streams): ReadableStream.read min option

b7019a6

fix converters and asserts

d7e4d02

littledivy reviewed Oct 11, 2023

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

add CoreGraphics

d88baf4

lino-levan mentioned this pull request Oct 14, 2023

WebGPU doesn't work on versions of deno >= 1.32 denoland/webgpu-examples#13

Closed

petamoriken reviewed Nov 23, 2023

View reviewed changes

ry mentioned this pull request Nov 28, 2023

feat: lazy loaded esm sources denoland/deno_core#263

Merged

crowlKats and others added 11 commits November 29, 2023 09:52

Update ext/webgpu/01_webgpu.js

e7e024b

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Update ext/webgpu/01_webgpu.js

a5dc8f2

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Update ext/webgpu/01_webgpu.js

15c8e6a

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Update ext/webgpu/01_webgpu.js

f3d8934

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Update ext/webgpu/01_webgpu.js

c0ac159

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Update ext/webgpu/01_webgpu.js

59e5b5d

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Update ext/webgpu/01_webgpu.js

786de65

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Apply suggestions from code review

b142f39

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

Update ext/webgpu/01_webgpu.js

c47e3ff

Co-authored-by: Kenta Moriuchi <moriken@kimamass.com> Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>

address comments

d317f0c

Merge branch 'main' into webgpu

91532f1

# Conflicts: # Cargo.lock # Cargo.toml # cli/js/40_testing.js # tools/README.md

crowlKats and others added 6 commits December 7, 2023 22:18

Merge branch 'main' into webgpu

7665e8e

update wgpu

bb0bd0e

fix the build

569fd1b

pin reqwest

0602fc6

fix

ab295e5

fix unstable flag order

68465cb

crowlKats mentioned this pull request Dec 8, 2023

Reintroduce WebGPU API #21514

Closed

crowlKats added 6 commits December 8, 2023 13:45

fix test

14f0375

update macos_shared_libraries to check for weak linking

bbdba51

Merge branch 'main' into webgpu

76d5234

fix unstable handling

99fa18b

fmt

3800f11

fix test

6c91999

Merge branch 'main' into webgpu

dcd94a2

# Conflicts: # Cargo.lock # Cargo.toml

bartlomieju reviewed Dec 8, 2023

View reviewed changes

crowlKats added 2 commits December 8, 2023 23:29

adress comments

1efcd93

fmt

42aff1b

bartlomieju approved these changes Dec 8, 2023

View reviewed changes

crowlKats merged commit 393abed into denoland:main Dec 9, 2023

crowlKats deleted the webgpu branch December 9, 2023 00:19

birkskyum mentioned this pull request Dec 19, 2023

WebGPU support oven-sh/bun#7380

Open

Conversation

crowlKats commented Oct 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sigmaSd commented Oct 6, 2023

Uh oh!

lino-levan commented Oct 10, 2023

Uh oh!

hastebrot commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

crowlKats commented Oct 11, 2023

Uh oh!

chances commented Oct 20, 2023

Uh oh!

crowlKats commented Oct 20, 2023

Uh oh!

petamoriken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KnorpelSenf commented Dec 8, 2023

Uh oh!

ry commented Dec 8, 2023

Uh oh!

crowlKats commented Dec 8, 2023

Uh oh!

crowlKats commented Dec 8, 2023

Uh oh!

bartlomieju commented Dec 8, 2023

Uh oh!

mmastrac commented Dec 8, 2023

Uh oh!

denobot commented Dec 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

startup_hello_world

startup_nop_empty

startup_nop_trivial

Uh oh!

mmastrac commented Dec 8, 2023

Uh oh!

Uh oh!

bartlomieju Dec 8, 2023

Choose a reason for hiding this comment

Uh oh!

crowlKats Dec 8, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bartlomieju Dec 8, 2023

Choose a reason for hiding this comment

Uh oh!

crowlKats Dec 8, 2023

Choose a reason for hiding this comment

Uh oh!

lino-levan commented Dec 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

crowlKats commented Oct 6, 2023 •

edited

Loading

hastebrot commented Oct 11, 2023 •

edited

Loading

denobot commented Dec 8, 2023 •

edited

Loading