Skip to content

feat(ext/net): support cert, key options in listenTls#13740

Merged
kt3k merged 1 commit into
denoland:mainfrom
kt3k:feat/tls-listen-cert-on-memory
Feb 24, 2022
Merged

feat(ext/net): support cert, key options in listenTls#13740
kt3k merged 1 commit into
denoland:mainfrom
kt3k:feat/tls-listen-cert-on-memory

Conversation

@kt3k

@kt3k kt3k commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

This PR adds cert: string and key: string options to Deno.listenTls and deprecates certFile and keyFile options.

You can specify the cert and private key from any source now. The read permission is checked only when certFile or keyFile is specified

closes #12639

@bartlomieju bartlomieju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 3e8180c into denoland:main Feb 24, 2022
@kt3k kt3k deleted the feat/tls-listen-cert-on-memory branch February 24, 2022 04:16
@kt3k kt3k mentioned this pull request Aug 23, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat. request] Allow reading CA certificate and key file from a variable instead of a file.

2 participants