ubuntu-latest -> ubuntu-20.04 when building libsqlite3.so
#86
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There really seems to be an issue with functions test - seems flaky, it's also causing #81 CI to fail. I'll look into it as soon as possible. |
Member
|
Let's try merging it, the error may have been fixed already on main Edit: It does work, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #80 (comment) , the current
libsqlite3.socauses some people to get this type of error:This is because dynamic library that are compiled on a computer with a high glibc version can't be ran on computers with a lower glibc version. The
ubuntu-latestrunner (v22.04) has glib v2.33, but people who are running ubuntu 18/20 or other linux OS with a lower glibc version can't run it.So this PR changes the action to use
ubuntu-20.04, so it's more compatible with more people. People runningubuntu-18.04still won't be able to use it, which sucks, but theubuntu-18.04GH action runner will be deprecated April 2023.Another option is a custom Dockerfile that runs a OS with a very low libc version, but that isn't very easy