add: iter method to iterate with params #133
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also breaks backwards compatibility as bound statements are no longer iterable. This worked before const [row] = db.prepare(`SELECT sqlite_version() AS ver WHERE ver > ?`).bind(0)But now it throws with: error: Uncaught (in promise) Error: Statement already bound to values
if (this.#bound) throw new Error("Statement already bound to values");
^
at Statement.#bindAll (https://jsr.io/@db/sqlite/0.12.0/src/statement.ts:376:28)
at Statement.iter (https://jsr.io/@db/sqlite/0.12.0/src/statement.ts:703:18)
at iter.next (<anonymous>)
at file:///<snipped>.ts:4:8
at eventLoopTick (ext:core/01_core.js:175:7) |
Member
|
Ohh, there's a little detail I missed here - it's always resetting binding values. I'll push a fix and make a new release. Thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
itermethod that accepts arguments to allow iterating through results.Symbol[Iterator]works for ones without any args.iterthat works both with and without bind values.Why
Without this, there's no way to iterate on large results efficiently. The current
allmethods and other variants always have to return the full query, which is not an ideal way to scan through the DB.Alternative approaches
Symbol[iterator]works for items without bind params, but any bind params will be reset on execution. Can just remove the resetting, but in that case, it breaks compatibility and older behavior, since it's the responsibility of the user of the prepared statement to ensure it's also reset and bound.