Skip to content

added types to transaction to infer types from passed function #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DjDeveloperr merged 2 commits into from
May 25, 2023
Merged

added types to transaction to infer types from passed function #103

DjDeveloperr merged 2 commits into from
May 25, 2023

Conversation

@sant123
Copy link
Contributor

@sant123 sant123 commented Apr 9, 2023

Now when passing a function into db.transaction, the returned function will infer the argument types from the provided function.

image
image

@sant123
Copy link
Contributor Author

sant123 commented May 23, 2023

@DjDeveloperr please could you take a look?

DjDeveloperr
DjDeveloperr approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DjDeveloperr DjDeveloperr merged commit 44a7da0 into denodrivers:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sant123 @DjDeveloperr