Skip to content

Move Deduplicate P2P & Collective#15

Merged
dengwxn merged 7 commits intodengwxn:ccar-0905from
AndyUB:test-1017
Oct 20, 2024
Merged

Move Deduplicate P2P & Collective#15
dengwxn merged 7 commits intodengwxn:ccar-0905from
AndyUB:test-1017

Conversation

@AndyUB
Copy link
Copy Markdown
Collaborator

@AndyUB AndyUB commented Oct 18, 2024

What is done?

The tests for p2p and collective deduplication, custom comm deduplication, and custom comm init & teardown no longer require GPU.

Mock both init and teardown of NCCL groups.

What is experimental?

Not sure if some channel creation depends on GPU.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
Signed-off-by: Yuhan Ruan <andyubryh@gmail.com>
@dengwxn dengwxn merged commit d8c85fb into dengwxn:ccar-0905 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants