add watch option to automatically rebuild on source file modification#35
Merged
demonnic merged 1 commit intodemonnic:mainfrom Apr 14, 2024
Merged
add watch option to automatically rebuild on source file modification#35demonnic merged 1 commit intodemonnic:mainfrom
demonnic merged 1 commit intodemonnic:mainfrom
Conversation
Owner
|
At first glance this looks just fine. I'll want to give it a practical test in the morning before merging and doing a release, but by and large should make it in. |
Owner
|
Sorry this took so long. Looks good, tests out, merging and releasing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pretty much what it says on the tin. It's pretty rudimentary since the majority of the nicer file modification mechanisms aren't implemented in the filesystem layer that Microsoft uses for WSL2 and, hence, don't trigger for docker under Windows. When a file changes in the
srcdirectory, it just runs the build process when it picks up the changed modification time on a regular 1 second interval. I've run the java jar and docker test image against the test packages without incident on Windows and in WSL.I'm not a groovy dev and was assisted by an LLM. I've scoured the docs for the code used and everything seems alright, but I'm not up on idiomatic Groovy by any means and am more than open to feedback.