fixed/dynamic mixed suggestion#5
Merged
demonnic merged 2 commits intodemonnic:donot_resize_if_not_dynamicfrom Jun 29, 2020
Merged
fixed/dynamic mixed suggestion#5demonnic merged 2 commits intodemonnic:donot_resize_if_not_dynamicfrom
demonnic merged 2 commits intodemonnic:donot_resize_if_not_dynamicfrom
Conversation
demonnic
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Suggestion for solving the issue I just described in Mudlet#3941 (comment)
Other info (issues closed, discussion etc)
I'm aware that this introduces the previous bad performance if someone uses a HBox with properties Geyser.Fixed
but this is imho a needed tradeoff if using Fixed and Dynamic elements together.
If you or someone else has a better idea/way that would be awesome.
I already planned to rewrite HBox/VBoxes as I'm not happy with the last pr Mudlet#3909 but I couldn't find the time to do it lately.