New error codes definitions for Unity API#92
Merged
Conversation
…d volume deletion. Also removed unused code.
Contributor
|
Looks like a UT coverage decrease. Code looks good, but we're below threshold now. |
anathoodell
previously approved these changes
Jun 24, 2025
alikdell
previously approved these changes
Jun 25, 2025
Collaborator
|
Can you cleanup codewoners, and add a Bears and Lumens team member in codeowner. |
Contributor
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
JacobGros
approved these changes
Jun 25, 2025
kumarkgosa
approved these changes
Jun 25, 2025
|
Force merging because this PR updates the correct list of CodeOwners for this repository. The only remaining check was due to CodeOwner approval which was blocking this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR defines more Unity API error codes, allowing the gounity caller to handle API errors more granularly.
This PR also eliminates a redundant http GET request that had no effect.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?