Skip to content

Refactor code to add interface#79

Merged
rishabhatdell merged 10 commits into
mainfrom
refactor-unity-client
Mar 10, 2025
Merged

Refactor code to add interface#79
rishabhatdell merged 10 commits into
mainfrom
refactor-unity-client

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Feb 4, 2025 •
edited by anandrajak1
Loading

Copy link
Copy Markdown
Contributor

Description

Refactor code to add interface

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Sanity scale testing result : cert-csi test scaling --sc unity-nfs
1

Sanity volume io testing result : cert-csi test vio --sc unity-nfs
2

@karthikk92 karthikk92 changed the title [WIP] Refactor code to add interface Refactor code to add interface Mar 10, 2025
@github-actions

github-actions Bot commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gounity 90.06% (-0.01%) 👎
github.com/dell/gounity/mocks 0.00% (ø)
github.com/dell/gounity/mocks/api 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gounity/filesystem.go 91.34% (-0.11%) 231 (-3) 211 (-3) 20 👎
github.com/dell/gounity/host.go 90.91% (-0.07%) 121 (-1) 110 (-1) 11 👎
github.com/dell/gounity/ipinterface.go 100.00% (ø) 12 (-1) 12 (-1) 0
github.com/dell/gounity/metrics.go 97.92% (-0.04%) 48 (-1) 47 (-1) 1 👎
github.com/dell/gounity/mocks/UnityClient.go 0.00% (ø) 0 0 0
github.com/dell/gounity/mocks/api/Client.go 0.00% (ø) 0 0 0
github.com/dell/gounity/snapshot.go 89.76% (-0.16%) 127 (-2) 114 (-2) 13 👎
github.com/dell/gounity/storagepool.go 100.00% (ø) 14 (-1) 14 (-1) 0
github.com/dell/gounity/unityclient.go 83.65% (+0.16%) 104 (+1) 87 (+1) 17 👍
github.com/dell/gounity/volume.go 88.20% (+0.36%) 178 (-3) 157 (-2) 21 (-1) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gounity/filesystem_test.go
  • github.com/dell/gounity/host_test.go
  • github.com/dell/gounity/ipinterface_test.go
  • github.com/dell/gounity/main_test.go
  • github.com/dell/gounity/metrics_test.go
  • github.com/dell/gounity/snapshot_test.go
  • github.com/dell/gounity/storagepool_test.go
  • github.com/dell/gounity/unityclient_test.go
  • github.com/dell/gounity/volume_test.go

@rishabhatdell rishabhatdell marked this pull request as ready for review March 10, 2025 06:34
@rishabhatdell rishabhatdell merged commit dbbfb3c into main Mar 10, 2025
@rishabhatdell rishabhatdell deleted the refactor-unity-client branch March 10, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@bandak2 bandak2 Awaiting requested review from bandak2

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@panigs7 panigs7 Awaiting requested review from panigs7

2 more reviewers

@karthikk92 karthikk92 karthikk92 approved these changes

@rishabhatdell rishabhatdell rishabhatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AkshaySainiDell @karthikk92 @rishabhatdell @suryagupta4