Skip to content

Added secret inheritance for release action#71

Merged
harishp8889 merged 2 commits into
mainfrom
secret-inherit
Feb 7, 2025
Merged

Added secret inheritance for release action#71
harishp8889 merged 2 commits into
mainfrom
secret-inherit

Conversation

@harishp8889

@harishp8889 harishp8889 commented Jan 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Added secret inheritance for release action

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

suryagupta4
suryagupta4 previously approved these changes Jan 13, 2025
View reviewed changes
donatwork
donatwork previously approved these changes Jan 22, 2025
View reviewed changes
@harishp8889 harishp8889 dismissed stale reviews from donatwork and suryagupta4 via 3c48976 January 27, 2025 12:53
@harishp8889 harishp8889 merged commit 167572f into main Feb 7, 2025
@harishp8889 harishp8889 deleted the secret-inherit branch February 7, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@panigs7 panigs7 Awaiting requested review from panigs7

4 more reviewers

@bandak2 bandak2 bandak2 approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@donatwork donatwork donatwork left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@harishp8889 @donatwork @bandak2 @karthikk92 @suryagupta4