Change timeout vars to use time.Duration instead of int64#203
Merged
Conversation
lukeatdell
approved these changes
Aug 15, 2025
falfaroc
approved these changes
Aug 18, 2025
donatwork
approved these changes
Aug 18, 2025
eebbb5e to
b4d5bf4
Compare
b4d5bf4 to
9886f51
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
donatwork
approved these changes
Aug 18, 2025
falfaroc
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
GitHub Issues
List the GitHub issues impacted by this PR:
| GitHub Issue # |
https://github.com/dell/csm/issues/1961
Common PR Checklist:
Description of your changes:
Adding these changes more for consistency and to prevent accidental type conversions that might cause timeouts to go negative and cause context deadline issues. This also makes it easier for timeouts to be passed from driver efficiently. Inherently time.Duration does use int64 to represent time in nanoseconds.
This is first step as part of making timeouts configurable.
Why do we need this?
timeout can be specified as 10s, 2m, etc. the time.ParseDuration returns time in time.Duration instead of int64 and it makes it easier to take that value and pass it in the client in gopowerstore. When creating a new client, we used time.Duration(timeout)*time.Second. This would overflow when time.Duration is passed in via the driver as int64 representation of the time in nanoseconds (which is default). overflow would cause time to be negative.
Why was this not an issue in the past?
Timeouts were hardcoded and not read in dynamically.
Unit test: