Skip to content

Add ListFS method#199

Merged
chimanjain merged 4 commits into
mainfrom
usr/chiman/listfs
Jun 30, 2025
Merged

Add ListFS method#199
chimanjain merged 4 commits into
mainfrom
usr/chiman/listfs

Conversation

@chimanjain

@chimanjain chimanjain commented Jun 27, 2025

Copy link
Copy Markdown
Contributor
  • Add ListFS method for listing Filesystems
  • Update Mocks

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility?
  • Have you updated the mocks for any Client functions that have been modified (mocks/Client.go)?

Installed the driver with the changes and added unit test.

@santhoshatdell santhoshatdell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update copyright year in changed files.

Comment thread client.go
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gopowerstore 91.82% (+0.09%) 👍
github.com/dell/gopowerstore/mocks 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gopowerstore/client.go 58.33% (ø) 36 21 15
github.com/dell/gopowerstore/fs.go 96.43% (+0.33%) 140 (+12) 135 (+12) 5 👍
github.com/dell/gopowerstore/mocks/Client.go 0.00% (ø) 0 0 0
github.com/dell/gopowerstore/mocks/FieldProvider.go 0.00% (ø) 0 0 0
github.com/dell/gopowerstore/mocks/Logger.go 0.00% (ø) 0 0 0
github.com/dell/gopowerstore/mocks/QueryParamsEncoder.go 0.00% (ø) 0 0 0
github.com/dell/gopowerstore/mocks/RequestConfigRenderer.go 0.00% (ø) 0 0 0
github.com/dell/gopowerstore/mocks/TimeoutSemaphoreInterface.go 0.00% (ø) 0 0 0
github.com/dell/gopowerstore/mocks/Traceable.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gopowerstore/fs_test.go

@chimanjain

Copy link
Copy Markdown
Contributor Author

Update copyright year in changed files.

Done

@chimanjain chimanjain merged commit d307fe4 into main Jun 30, 2025
6 checks passed
@chimanjain chimanjain deleted the usr/chiman/listfs branch June 30, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants