Skip to content

Added FSCreationLimitReached Error#196

Merged
rishabhatdell merged 5 commits into
mainfrom
multi-nas-support
May 8, 2025
Merged

Added FSCreationLimitReached Error#196
rishabhatdell merged 5 commits into
mainfrom
multi-nas-support

Conversation

@rishabhatdell

@rishabhatdell rishabhatdell commented May 7, 2025

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1758

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility?
  • Have you updated the mocks for any Client functions that have been modified (mocks/Client.go)?

Description of your changes:

Added FSCreationLimitReached() method in APIError to correctly detect NAS FS creation limit errors using:

  • HTTP 422 status
  • Message substring "limit of 125 file systems for the NAS server"

suryagupta4
suryagupta4 previously approved these changes May 7, 2025
View reviewed changes
AkshaySainiDell
AkshaySainiDell previously approved these changes May 7, 2025
View reviewed changes
karthikk92
karthikk92 reviewed May 7, 2025
View reviewed changes
Comment thread gopowerstore_types_test.go
santhoshatdell
santhoshatdell reviewed May 7, 2025
View reviewed changes
Comment thread gopowerstore_types.go Outdated
@rishabhatdell rishabhatdell dismissed stale reviews from AkshaySainiDell and suryagupta4 via 8326823 May 8, 2025 05:22
karthikk92
karthikk92 previously approved these changes May 8, 2025
View reviewed changes
@github-actions

github-actions Bot commented May 8, 2025

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gopowerstore 91.73% (+0.01%) 👍
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gopowerstore/gopowerstore_types.go 84.44% (+0.35%) 45 (+1) 38 (+1) 7 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gopowerstore/gopowerstore_types_test.go

@rishabhatdell rishabhatdell merged commit 0638255 into main May 8, 2025
6 checks passed
@rishabhatdell rishabhatdell deleted the multi-nas-support branch May 8, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@lukeatdell lukeatdell Awaiting requested review from lukeatdell

4 more reviewers

@santhoshatdell santhoshatdell santhoshatdell left review comments

@karthikk92 karthikk92 karthikk92 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rishabhatdell @karthikk92 @AkshaySainiDell @suryagupta4 @santhoshatdell