Skip to content

failing check removed for int test#191

Merged
Sakshi-dell merged 1 commit into
mainfrom
int-test-fix
Mar 24, 2025
Merged

failing check removed for int test#191
Sakshi-dell merged 1 commit into
mainfrom
int-test-fix

Conversation

@Sakshi-dell

@Sakshi-dell Sakshi-dell commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility?
  • Have you updated the mocks for any Client functions that have been modified (mocks/Client.go)?

Description of your changes:

A check was failing in integration test, as ID will change in each run so we cannot assert the same.
image

@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gopowerstore/inttests 0.00% (ø)

Coverage by file

Changed unit test files

  • github.com/dell/gopowerstore/inttests/metrics_test.go

@Sakshi-dell Sakshi-dell merged commit d3a762b into main Mar 24, 2025
@Sakshi-dell Sakshi-dell deleted the int-test-fix branch March 24, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants