Skip to content

remove omitempty from UID & GID [NFS Export Create], as zeroID is valid value#189

Merged
Krishnan-Priyanshu merged 1 commit into
mainfrom
nfs_create_fix
Mar 19, 2025
Merged

remove omitempty from UID & GID [NFS Export Create], as zeroID is valid value#189
Krishnan-Priyanshu merged 1 commit into
mainfrom
nfs_create_fix

Conversation

@Krishnan-Priyanshu

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility?
  • Have you updated the mocks for any Client functions that have been modified (mocks/Client.go)?

Description of your changes:

remove omitempty from UID & GID [NFS Export Create], as zeroID is valid value

@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gopowerstore 91.72% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gopowerstore/nfs_types.go 100.00% (ø) 2 2 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@Krishnan-Priyanshu Krishnan-Priyanshu merged commit af67f09 into main Mar 19, 2025
@Krishnan-Priyanshu Krishnan-Priyanshu deleted the nfs_create_fix branch March 19, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants