Handled returning fields based on array version for NAS server#188
Merged
Conversation
karthikk92
reviewed
Mar 14, 2025
Contributor
|
@akshay-sripriya: Please add unit tests for the changes added and make sure overall coverage is not decreased, thanks. |
karthikk92
previously approved these changes
Mar 17, 2025
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Contributor
Author
Tests have been added |
AkshaySainiDell
approved these changes
Mar 17, 2025
suryagupta4
approved these changes
Mar 17, 2025
santhoshatdell
approved these changes
Mar 17, 2025
karthikk92
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common PR Checklist:
Description of your changes:
The "is_dr_test" attribute in NAS Server, is not applicable to array versions 3.6 and below but is applicable to array versions above 3.6. Thus, the fields have to be returned based on array version.