Skip to content

Updated GetNASServers to return FileSystems & NAS Health#187

Merged
rishabhatdell merged 3 commits into
mainfrom
feature/multi-nas-support
Mar 17, 2025
Merged

Updated GetNASServers to return FileSystems & NAS Health#187
rishabhatdell merged 3 commits into
mainfrom
feature/multi-nas-support

Conversation

@rishabhatdell

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1758

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility?
  • Have you updated the mocks for any Client functions that have been modified (mocks/Client.go)?

Description of your changes:

Added FIleSystem and HealthDetails in GetNASServers

santhoshatdell
santhoshatdell previously approved these changes Mar 12, 2025
suryagupta4
suryagupta4 previously approved these changes Mar 13, 2025
karthikk92
karthikk92 previously approved these changes Mar 13, 2025
santhoshatdell
santhoshatdell previously approved these changes Mar 13, 2025
Comment thread fs_types.go Outdated
@rishabhatdell rishabhatdell dismissed stale reviews from karthikk92 and suryagupta4 via 0209fb1 March 14, 2025 04:54
@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gopowerstore 91.63% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gopowerstore/fs_types.go 100.00% (ø) 9 9 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@rishabhatdell rishabhatdell merged commit f8ea2d5 into main Mar 17, 2025
@rishabhatdell rishabhatdell deleted the feature/multi-nas-support branch March 17, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants