Skip to content

Adding method to filter remote systems by any filters#181

Merged
rounak-adhikary merged 4 commits into
mainfrom
remote-system-read
Feb 18, 2025
Merged

Adding method to filter remote systems by any filters#181
rounak-adhikary merged 4 commits into
mainfrom
remote-system-read

Conversation

@rounak-adhikary

@rounak-adhikary rounak-adhikary commented Feb 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/terraform-provider-powerstore/issues/120

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Adding method to filter remote systems by any filters

Tested By

  • Unit Tests
  • Integration Tests

Test Logs

root@lglap049:~/gopowerstore# go test ./inttests/ -run TestGetRemoteSystems
ok      github.com/dell/gopowerstore/inttests   0.281s
root@lglap049:~/gopowerstore#

@rounak-adhikary

rounak-adhikary commented Feb 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The failure seems to be due to changes in dell/common-github-actions/ rather than my code.
The failure has been fixed now.

@rounak-adhikary rounak-adhikary mentioned this pull request Feb 17, 2025
Merged
9 tasks
abhi16394
abhi16394 reviewed Feb 18, 2025
View reviewed changes

@abhi16394 abhi16394 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you post results of how this has been tested.

@rounak-adhikary rounak-adhikary merged commit 3545eab into main Feb 18, 2025
@rounak-adhikary rounak-adhikary deleted the remote-system-read branch February 18, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shenda1 shenda1 Awaiting requested review from shenda1

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@donatwork donatwork Awaiting requested review from donatwork

@lukeatdell lukeatdell Awaiting requested review from lukeatdell

@abhi16394 abhi16394 Awaiting requested review from abhi16394

2 more reviewers

@Sakshi-dell Sakshi-dell Sakshi-dell approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rounak-adhikary @abhi16394 @Sakshi-dell @santhoshatdell