Skip to content

NFS Export new fields added#163

Merged
Sakshi-dell merged 4 commits into
mainfrom
NFS-export-update
Jan 7, 2025
Merged

NFS Export new fields added#163
Sakshi-dell merged 4 commits into
mainfrom
NFS-export-update

Conversation

@Sakshi-dell

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/terraform-provider-powerstore#124

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

A new NFS export resource will be added on terraform-provider-powerstore so added new fields for the same
updated bool to *bool, for is_write_order_consistent attribute in volume group, since it was not working with false value of the bool field

image

Comment thread nfs_types.go Outdated
NoAccessHosts []string `json:"no_access_hosts,omitempty"`
// Hosts with read-only access to the NFS export and its snapshots.
ReadOnlyHosts []string `json:"read_only_hosts,omitempty"`
// Hosts with read-only and ready-only for root user access to the NFS Export and its snapshots.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready-only -> read-only?

@Sakshi-dell Sakshi-dell merged commit 9ec041e into main Jan 7, 2025
@Sakshi-dell Sakshi-dell deleted the NFS-export-update branch January 7, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants