Skip to content

order by time#143

Merged
nitesh3108 merged 1 commit into
mainfrom
replication-obs-metrics
Oct 11, 2024
Merged

order by time#143
nitesh3108 merged 1 commit into
mainfrom
replication-obs-metrics

Conversation

@nitesh3108

Copy link
Copy Markdown
Contributor

PR Submission checklist

Set order by timestamp and fetch the latest record only.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1443

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

After updating the select query parameter using order by time stamp and limit as 1, it fetches the latest record and is consistent across other params being fetched.

time="2024-10-11T11:33:15Z" level=debug msg="persistent volume is not nfs" persistent_volume=csivol-86b3213c6b protocol=scsi time="2024-10-11T11:33:22Z" level=debug msg="volume metrics" mirror_bandwidth=711.6486 read_bandwidth=0 read_iops=0 read_latency=0 remaining_data=0 syncronization_bandwidth=0 volume_meta="&{c2d584c3-b4f1-41d7-8ac7-14fa14ca6e5c csivol-86b3213c6b pvol-metro-136 default PS30ddf4e1d754 }" write_bandwidth=711.6486 write_iops=712.6 write_latency=5.496929

@shefali-malhotra shefali-malhotra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitesh3108 nitesh3108 merged commit 92570cd into main Oct 11, 2024
@nitesh3108 nitesh3108 deleted the replication-obs-metrics branch October 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants