Replication observability metrics#142
Merged
Merged
Conversation
412cfdd to
a56eb51
Compare
adarsh-dell
reviewed
Oct 8, 2024
adarsh-dell
reviewed
Oct 8, 2024
| // VolumeMirrorTransferRate - Volume Mirror Transfer Rate | ||
| func (c *ClientIMPL) VolumeMirrorTransferRate(ctx context.Context, entityID string) ([]VolumeMirrorTransferRateResponse, error) { | ||
| var resp []VolumeMirrorTransferRateResponse | ||
| err := c.mirrorTransferRate(ctx, &resp, entityID, 2000) |
Contributor
There was a problem hiding this comment.
Can this 2000 be a constant value instead of hardcoding it here like this way?
863ab1e to
04451e6
Compare
AkshaySainiDell
suggested changes
Oct 8, 2024
| if err != nil { | ||
| err = WrapErr(err) | ||
| } | ||
| customHeader.Del("DELL-VISIBILITY") |
Contributor
There was a problem hiding this comment.
Suggested change
| customHeader.Del("DELL-VISIBILITY") | |
| customHeader.Del("DELL-VISIBILITY") | |
| apiClient.SetCustomHTTPHeaders(customHeader) |
adarsh-dell
previously approved these changes
Oct 8, 2024
adarsh-dell
approved these changes
Oct 8, 2024
AkshaySainiDell
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
It enables API support for volume_mirror_transfer_rate_cma_view which will be helpful to pull the Replication related stats for Sync and Metro at volume level.
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
Earlier unit-test report
Current unit-test report