Volume Group Snapshot Modify Fix#124
Merged
Merged
Conversation
Contributor
Author
|
I ran |
Contributor
|
Hi @doriac11 , Will it be possible to add the mock and UT for this new method? |
- When modifing a volume group snapshot, if the protection policy id field is set it will cause the API to fail. Created a seperate method for VGsnapshotModify with a different body.
bbb6c09 to
72ef03e
Compare
Contributor
Author
Added the UTs and Mock Data, screenshots in the description. |
shekhar-j
previously approved these changes
Feb 14, 2024
nikitajoshi1
previously approved these changes
Feb 14, 2024
Contributor
95e161d
12ec759 to
f05c786
Compare
f05c786 to
14b1c64
Compare
14b1c64 to
abbef3c
Compare
AkshaySainiDell
approved these changes
Feb 15, 2024
adarsh-dell
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common PR Checklist:
Description of your changes:
Test Output for new tests
Coverage of new method (100%)