Fixing clonevolume error scenario#97
Merged
Merged
Conversation
rishabhatdell
previously approved these changes
Mar 17, 2025
donatwork
reviewed
Mar 17, 2025
donatwork
reviewed
Mar 17, 2025
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
donatwork
approved these changes
Mar 17, 2025
AkshaySainiDell
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
Clone volume function was not checking for copy errors in the response given by the api. These changes also check for any errors in response and return error.
Tested by building image and cloning the volume manually where driver is running with guest credentials in secret file:
Expected behavior now is that driver must not allow volume to clone and hence volume remains in pending state. Also must log appropriate error message
Cert-csi runs successfully :
cert-csi- when user is guest.txt
When running driver with a root credentials
Expected behavior now is that driver must allow volume to clone
Cert-csi runs successfully :
cert-csi- when user is root.txt