Skip to content

Added secret inheritance for release action#83

Merged
donatwork merged 4 commits into
mainfrom
secrets-inherit
Feb 19, 2025
Merged

Added secret inheritance for release action#83
donatwork merged 4 commits into
mainfrom
secrets-inherit

Conversation

@harishp8889

@harishp8889 harishp8889 commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1490

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Added secret inheritance for release action
Tested against fork: https://github.com/harishp8889/test-gofsutil-automation/actions/runs/12724867954/job/35471506833

suryagupta4
suryagupta4 previously approved these changes Jan 13, 2025
nitesh3108
nitesh3108 previously approved these changes Jan 13, 2025
@nitesh3108

Copy link
Copy Markdown
Contributor

@harishp8889 UTs are failing, pls check

chimanjain
chimanjain previously approved these changes Jan 13, 2025
@harishp8889

Copy link
Copy Markdown
Contributor Author

@harishp8889 UTs are failing, pls check

They are failing in main branch only and there is no new change is introduced in this PR with respect to UT/functionality

atye
atye previously approved these changes Feb 19, 2025
@donatwork donatwork requested a review from atye February 19, 2025 20:51
@donatwork donatwork merged commit c2436e2 into main Feb 19, 2025
@donatwork donatwork deleted the secrets-inherit branch February 19, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants