Skip to content

Adding Query Parameter for listing snapshots for dellctl support#68

Merged
tdawe merged 2 commits into
mainfrom
dellctl-support
Aug 6, 2024
Merged

Adding Query Parameter for listing snapshots for dellctl support#68
tdawe merged 2 commits into
mainfrom
dellctl-support

Conversation

@harshitap26

@harshitap26 harshitap26 commented Aug 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1281

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Used these changes on cam-authorization and able to list the snapshots created and get the snapshot count as well

[root@master-1-DISXduyHx8XGU bin]# ./dellctl volume ls --insecure --namespace isilon --proxy https://csm-authorization.com:30495/
NAME                           VOLUME ID   SIZE       POOL            SYSTEM ID                   PV NAME                        PV STATUS   STORAGE CLASS   PVC NAME      NAMESPACE   SNAPSHOT COUNT
k8s-csmtn1-sample-5e5557d921   478376      0.000000   /ifs/data/csi   PIE-IsilonS-24241-Cluster   k8s-csmtn1-sample-5e5557d921   Bound       isilon          pvol-isilon   default     2

[root@master-1-DISXduyHx8XGU bin]# ./dellctl snapshot ls --insecure --namespace isilon --proxy https://csm-authorization.com:30495/
NAME                                            SNAPSHOT ID   SIZE       POOL            SYSTEM ID                   ACCESS MODE   SOURCE VOLUME ID
snapshot-7d79bb9c-29e4-4796-b26e-47a6a31910fb   368472        0.000006   /ifs/data/csi   PIE-IsilonS-24241-Cluster                 478376
snapshot-afd0a9c4-156c-4b53-b828-52bba312cb20   368474        0.000006   /ifs/data/csi   PIE-IsilonS-24241-Cluster                 478376

@harshitap26 harshitap26 marked this pull request as ready for review August 5, 2024 06:38
shefali-malhotra
shefali-malhotra approved these changes Aug 6, 2024
View reviewed changes

@shefali-malhotra shefali-malhotra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdawe tdawe merged commit aff0b89 into main Aug 6, 2024
@tdawe tdawe deleted the dellctl-support branch August 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@meggm meggm Awaiting requested review from meggm

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@tdawe tdawe Awaiting requested review from tdawe

@falfaroc falfaroc Awaiting requested review from falfaroc

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

2 more reviewers

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harshitap26 @nitesh3108 @shefali-malhotra @tdawe