KRV-26417: Gosec issues skipped#67
Merged
Merged
Conversation
adarsh-dell
approved these changes
Jul 19, 2024
meggm
approved these changes
Jul 19, 2024
chimanjain
approved these changes
Jul 19, 2024
2d6ee41 to
65a5bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
Gosec issues skipped
CWE-798 : This one is false positive since there is no hardcoded content it is just a string
CWE-295 : We can't set InsecureSkipVerify as false or true always, anyways we are overriding the value later based on user input
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
Results:
Summary:
Gosec : dev
Files : 71
Lines : 15193
Nosec : 2
Issues : 0