Skip to content

Renaming utils package to give more context#102

Merged
alikdell merged 2 commits into
mainfrom
usr/lukeatdell/revive-linter-fix
Jul 2, 2025
Merged

Renaming utils package to give more context#102
alikdell merged 2 commits into
mainfrom
usr/lukeatdell/revive-linter-fix

Conversation

@lukeatdell

@lukeatdell lukeatdell commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Description

Renaming the utils package to give the package names more context and meaning.
This resolves issues uncovered by "revive" linting

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Tests

Kubernetes e2e - External Storage

  I0702 14:50:31.748683 24078 external.go:189] Driver loaded from path [./manifest.yaml]: &{DriverInfo:{Name:csi-isilon.dellemc.com InTreePluginName: TestTags:[] MaxFileSize:0 SupportedSizeRange:{Max: Min:8Gi} SupportedFsType:map[:{} nfs:{}] SupportedMountOption:map[] RequiredMountOption:map[] Capabilities:map[block:false capacity:false controllerExpansion:true exec:false fsGroup:false multipods:true nodeExpansion:true offlineExpansion:true onlineExpansion:true persistence:true pvcDataSource:true snapshotDataSource:true topology:true volumeLimits:false] RequiredAccessModes:[] TopologyKeys:[csi-isilon.dellemc.com/10.247.102.193] NumAllowedTopologies:0 StressTestOptions:<nil> VolumeSnapshotStressTestOptions:0xc000423a10 PerformanceTestOptions:<nil>} StorageClass:{FromName:false FromFile: FromExistingClassName:isilon} VolumeAttributesClass:{FromName:false FromFile: FromExistingClassName:} SnapshotClass:{FromName:false FromFile: FromExistingClassName:isilon-snapclass} InlineVolumes:[] ClientNodeName: Timeouts:map[]}
  I0702 14:50:32.587407   24078 e2e.go:109] Starting e2e run "d7b30785-b606-4dd5-aeba-d4d5840b2367" on Ginkgo node 1
Running Suite: Kubernetes e2e suite
===========================================================================
Random Seed: 1751482231 - will randomize all specs

Will run 189 of 7037 specs
Ran 37 of 7037 Specs in 1447.971 seconds
SUCCESS! -- 37 Passed | 0 Failed | 0 Pending | 7000 Skipped
PASS

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gopowerscale 0.00% (ø)
github.com/dell/gopowerscale/api/common/utils/poll 0.00% (ø)
github.com/dell/gopowerscale/api/common/utils/stringutils 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gopowerscale/api/common/utils/poll/poll.go 0.00% (ø) 0 0 0
github.com/dell/gopowerscale/api/common/utils/stringutils/string-utils.go 0.00% (ø) 0 0 0
github.com/dell/gopowerscale/exports.go 0.00% (ø) 0 0 0
github.com/dell/gopowerscale/replication.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gopowerscale/api/common/utils/poll/poll_test.go
  • github.com/dell/gopowerscale/api/common/utils/stringutils/string-utils_test.go

@lukeatdell

Copy link
Copy Markdown
Contributor Author

e2e test are pending

@alikdell alikdell merged commit 8f6ab64 into main Jul 2, 2025
6 checks passed
@alikdell alikdell deleted the usr/lukeatdell/revive-linter-fix branch July 2, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants