Allow multiple possible job states when polling for LastJobState#101
Merged
Conversation
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
8 tasks
santhoshatdell
approved these changes
Jul 2, 2025
falfaroc
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expand scope of
WaitForPolicyLastJobState()to accept a list of states, of which, at least one is desired.These changes are related to dell/csi-powerscale#412 and allows the
reprotectreplication action to wait for aRUNNINGorFINISHEDstate when trying to confirm the state of a newly created SyncIQ policy.GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Tests
Kubernetes e2e - External Storage
$ ./e2e.test I0702 15:37:33.218885 16383 external.go:189] Driver loaded from path [./manifest.yaml]: &{DriverInfo:{Name:csi-isilon.dellemc.com InTreePluginName: TestTags:[] MaxFileSize:0 SupportedSizeRange:{Max: Min:8Gi} SupportedFsType:map[:{} nfs:{}] SupportedMountOption:map[] RequiredMountOption:map[] Capabilities:map[block:false capacity:false controllerExpansion:true exec:false fsGroup:false multipods:true nodeExpansion:true offlineExpansion:true onlineExpansion:true persistence:true pvcDataSource:true snapshotDataSource:true topology:true volumeLimits:false] RequiredAccessModes:[] TopologyKeys:[csi-isilon.dellemc.com/10.247.102.193] NumAllowedTopologies:0 StressTestOptions:<nil> VolumeSnapshotStressTestOptions:0xc000aed3c0 PerformanceTestOptions:<nil>} StorageClass:{FromName:false FromFile: FromExistingClassName:isilon} VolumeAttributesClass:{FromName:false FromFile: FromExistingClassName:} SnapshotClass:{FromName:false FromFile: FromExistingClassName:isilon-snapclass} InlineVolumes:[] ClientNodeName: Timeouts:map[]} I0702 15:37:34.010988 16383 test_context.go:564] The --provider flag is not set. Continuing as if --provider=skeleton had been used. I0702 15:37:34.011126 16383 e2e.go:109] Starting e2e run "bf6ec656-08c8-46b4-9da9-3ee0f45726cb" on Ginkgo node 1 Running Suite: Kubernetes e2e suite =========================================================================== Random Seed: 1751485053 - will randomize all specs Will run 189 of 7037 specs SSSSSSSSSSSSSSSSSSSSSSSSS... Ran 37 of 7037 Specs in 1396.247 seconds SUCCESS! -- 37 Passed | 0 Failed | 0 Pending | 7000 Skipped PASS