Skip to content

Add method to list ports for a Symmetrix#95

Merged
AkshaySainiDell merged 6 commits into
mainfrom
bugfix-1826-fc-port-group
Apr 7, 2025
Merged

Add method to list ports for a Symmetrix#95
AkshaySainiDell merged 6 commits into
mainfrom
bugfix-1826-fc-port-group

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

We need a method to list ports for a Symmetrix based on the protocol. This functionality is added in gopowermax, allowing the driver to filter SCSI_FC ports

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1826

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed driver on a FC cluster and ran cert-csi scale test for powermax-fc storage class. Masking view and port group were deleted before running the test.

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review April 4, 2025 08:31
@AkshaySainiDell AkshaySainiDell requested a review from tdawe April 4, 2025 08:59
tdawe
tdawe reviewed Apr 4, 2025
View reviewed changes
Comment thread interface.go Outdated
tdawe
tdawe reviewed Apr 4, 2025
View reviewed changes
Comment thread sloprovisioning.go Outdated
santhoshatdell
santhoshatdell previously approved these changes Apr 4, 2025
View reviewed changes
Comment thread interface.go Outdated
suryagupta4
suryagupta4 previously approved these changes Apr 7, 2025
View reviewed changes
tdawe
tdawe reviewed Apr 7, 2025
View reviewed changes
Comment thread sloprovisioning_test.go Outdated
tdawe
tdawe previously approved these changes Apr 7, 2025
View reviewed changes
@AkshaySainiDell AkshaySainiDell dismissed stale reviews from tdawe and suryagupta4 via c296693 April 7, 2025 12:21
@github-actions

github-actions Bot commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gopowermax 0.00% (ø)
github.com/dell/gopowermax/mock 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gopowermax/interface.go 0.00% (ø) 0 0 0
github.com/dell/gopowermax/mock/mock.go 0.00% (ø) 0 0 0
github.com/dell/gopowermax/sloprovisioning.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gopowermax/sloprovisioning_test.go

@AkshaySainiDell AkshaySainiDell merged commit be5c9ff into main Apr 7, 2025
@AkshaySainiDell AkshaySainiDell deleted the bugfix-1826-fc-port-group branch April 7, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdawe tdawe tdawe approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

+3 more reviewers

@santhoshatdell santhoshatdell santhoshatdell left review comments

@karthikk92 karthikk92 karthikk92 approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AkshaySainiDell @tdawe @karthikk92 @suryagupta4 @santhoshatdell