Skip to content

Feature nvme tcp#63

Merged
nidtara merged 1 commit into
mainfrom
feature_nvme_tcp
Jun 3, 2024
Merged

Feature nvme tcp#63
nidtara merged 1 commit into
mainfrom
feature_nvme_tcp

Conversation

@nidtara

@nidtara nidtara commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

Description

Adding filter support to fetch NVMe target ports only (excluding iscsi targets)

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1308

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

update mock with fresh metrics

Signed-off-by: Utkarsh Dubey <Utkarsh.Dubey@Dell.com>

@delldubey delldubey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nidtara nidtara merged commit 59f78eb into main Jun 3, 2024
@shanmydell shanmydell deleted the feature_nvme_tcp branch October 16, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants